Conversation
added 4 commits
November 27, 2023 23:05
This reverts commit 6622118.
ghost
approved these changes
Nov 28, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Tested here https://dexory.atlassian.net/browse/AUTO-1640. GTG 👍🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dexory.atlassian.net/browse/AUTO-1589
Had to pull
nav2_utilsbut needed to revert 2 commits:Replaces #27.
Depends on https://github.com/botsandus/auto-virtual-safety-system/pull/8 otherwise the new default blocking behavior of the CM kicks in (we asked for this).
Looks like the good days of full nav2 main/iron compatibility are over... until jazzy. It is that time of the year.