Merged
Conversation
Follow up to: - #13
nachovizzo
approved these changes
Sep 4, 2024
nachovizzo
left a comment
There was a problem hiding this comment.
Thanks @ruffsl!
I will bake a release tomorrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add a missing declared dependency for the
packaginglibrary, as a follow up to:As can be seen in use here:
ament_black/ament_black/ament_black/main.py
Line 36 in 81af884
As for the minimum version number, I simply opted to use whatever shipped with Ubuntu 20.04.
We could probable go further back, as it looks to have been around awhile: