Make timestamp-parsing utils platform-independent #1970
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1939.
In general, this should make timestamp-parsing mostly platform-independent, since the use of platform-dependent methods such as
datetime.fromtimestamp()anddatetime.astimezone()are no longer being used. Instead, timestamps are manually offset from the Unix epoch, and are also localised manually.This PR comes with a new utility function,
botocore.utils.parse_posix_timestamp, which is simply a more specific version ofbotocore.utils.parse_timestamp.I also made a comment in the relevant tests to note that the tests seem to be written for machines where the timezone is UTC. Tests were failing for me before making any changes, until I ran the tests with the
TZ=UTCenv var.