Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Stopping flapping notifications and empty emails #1473

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Stopping flapping notifications and empty emails #1473

merged 1 commit into from
Nov 20, 2015

Conversation

captncraig
Copy link
Contributor

Fixes #1471

@captncraig
Copy link
Contributor Author

@gbrayut @kylebrandt

@captncraig captncraig mentioned this pull request Nov 18, 2015
Closed
@gbrayut
Copy link
Contributor

gbrayut commented Nov 18, 2015

LGTM but I'm not familiar with the check code. Probably should run in Denver for a bit to make sure it works as expected.

@captncraig captncraig mentioned this pull request Nov 19, 2015
Closed
@captncraig
Copy link
Contributor Author

fixes #1453

@captncraig
Copy link
Contributor Author

Honestly, I don't think denver will tell us much interesting since most of this is around notifications, which denver doesn't send.

@gbrayut
Copy link
Contributor

gbrayut commented Nov 19, 2015

It will tell us if there are major flaws in the check logic, but I'm fine either way

@captncraig captncraig merged commit 9f7ff68 into master Nov 20, 2015
@captncraig captncraig deleted the flapping branch December 1, 2015 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captncraig @gbrayut