Merge pull request quarkusio#37270 from mkouba/issue-37222

Vert.x: report exception for blocking message consumer methods
bosch-io · Nov 23, 2023 · 75cb5d2 · 75cb5d2
2 parents cd3a1d2 + 9917e6b
commit 75cb5d2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/...ertx/deployment/src/test/java/io/quarkus/vertx/deployment/MessageConsumerFailureTest.java b/...ertx/deployment/src/test/java/io/quarkus/vertx/deployment/MessageConsumerFailureTest.java
@@ -58,6 +58,12 @@ public void testFailure() throws InterruptedException {
 
     @Test
     public void testFailureNoReplyHandler() throws InterruptedException {
+        verifyFailureNoReply("foo", "Foo is dead", IllegalStateException.class);
+        verifyFailureNoReply("foo-blocking", "Red is dead", IllegalStateException.class);
+    }
+
+    void verifyFailureNoReply(String address, String expectedMessage, Class<? extends Exception> expectedException)
+            throws InterruptedException {
         Handler<Throwable> oldHandler = vertx.exceptionHandler();
         try {
             BlockingQueue<Object> synchronizer = new LinkedBlockingQueue<>();
@@ -71,10 +77,10 @@ public void handle(Throwable event) {
                     }
                 }
             });
-            eventBus.send("foo", "bar");
+            eventBus.send(address, "hello");
             Object ret = synchronizer.poll(2, TimeUnit.SECONDS);
-            assertTrue(ret instanceof IllegalStateException);
-            assertEquals("Foo is dead", ((IllegalStateException) ret).getMessage());
+            assertTrue(expectedException.isAssignableFrom(ret.getClass()));
+            assertEquals(expectedMessage, ((Throwable) ret).getMessage());
         } finally {
             vertx.exceptionHandler(oldHandler);
         }

diff --git a/...s/vertx/runtime/src/main/java/io/quarkus/vertx/runtime/VertxEventBusConsumerRecorder.java b/...s/vertx/runtime/src/main/java/io/quarkus/vertx/runtime/VertxEventBusConsumerRecorder.java
@@ -37,6 +37,7 @@
 import io.smallrye.common.vertx.VertxContext;
 import io.vertx.core.AsyncResult;
 import io.vertx.core.Context;
+import io.vertx.core.Future;
 import io.vertx.core.Handler;
 import io.vertx.core.Vertx;
 import io.vertx.core.eventbus.EventBus;
@@ -147,7 +148,7 @@ public void run() {
                                             }
                                         });
                                     } else {
-                                        dup.executeBlocking(new Callable<Void>() {
+                                        Future<Void> future = dup.executeBlocking(new Callable<Void>() {
                                             @Override
                                             public Void call() {
                                                 try {
@@ -163,6 +164,7 @@ public Void call() {
                                                 return null;
                                             }
                                         }, invoker.isOrdered());
+                                        future.onFailure(context::reportException);
                                     }
                                 } else {
                                     // Will run on the context used for the consumer registration.