Disable RTTI in C++ source#7
Closed
pcapriotti wants to merge 1 commit intobos:masterfrom
wireapp:master
Closed
Conversation
Also update to cabal 2.2, so that we can set the cxx-sources and cxx-options fields.
4 tasks
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 6, 2021
This selects a snappy branch containing a fix for a linker issue with libsnappy-1.1.9. The fix is in this PR: bos/snappy#7
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 6, 2021
This selects a snappy branch containing a fix for a linker issue with libsnappy-1.1.9. The fix is in this PR: bos/snappy#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a linker issue with libsnappy-1.1.9. Namely, RTTI has been disabled in 1.1.9 (see google/snappy@c98344f), but the haskell package is still compiling its C++ source file with RTTI enabled, which results in an unresolvable symbol (a typeinfo structure).
This PR migrates the cabal file to 2.2, and sets the cxx-sources and cxx-options field (just like #6) in order to disable RTTI.
More information
The
libsnappy-1.1.9shared object does not have any typeinfo symbols:Before this patch:
After this patch: