Ensure log levels are appropriately padded even on coloured outputs. #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all thanks for the library.
There was an issue when having colored output on Linux(Manjaro Linux with KDE to be specific), where coloured outputs had mis-padded logging
The issue came about with how coloring is done on Linux, i.e we add special characters in the command line, e.g printing color red would add
\033[39m
,Later on, when you tried to format the message with appropriate padding, for log levels
The colored log levels would not be padded because the string is longer than 5 characters, hence the misalignment above.
The fix was to simply do the padding before the coloring which fixes that misalignment,
now with this pr the printed output looks like
This is now in tandem with the no color output which would print with the appropriate padding
Hope it helps.