Skip to content

Support clojure-ts-mode #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borkdude merged 3 commits into from
Feb 3, 2024
Merged

Support clojure-ts-mode #26

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0f906
Support clojure-ts-mode #25
kommen Feb 1, 2024
368bbb0
Update docstring, ensure backwards compatibility
kommen Feb 2, 2024
24438be
Fix typo
kommen Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions flycheck-clj-kondo.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@
your file extension doesn't match your major-mode.")

(defmacro flycheck-clj-kondo--define-checker
(name lang mode &rest extra-args)
(name lang modes &rest extra-args)
Comment thread
borkdude marked this conversation as resolved.
"Internal macro to define checker.
Argument NAME: the name of the checker.
Argument LANG: language string.
Argument MODE: the mode in which this checker is activated.
Argument MODES: a major mode symbol or a list thereof in which this checker is activated.
Argument EXTRA-ARGS: passes extra args to the checker."
`(flycheck-define-checker ,name
"See https://github.com/borkdude/clj-kondo"
Expand All @@ -74,7 +74,7 @@ Argument EXTRA-ARGS: passes extra args to the checker."
":" line ":" column ": " (0+ not-newline) "warning: " (message) line-end)
(info line-start (or "<stdin>" (file-name))
":" line ":" column ": " (0+ not-newline) "info: " (message) line-end))
:modes (,mode)
:modes ,modes
:predicate (lambda ()
(or
;; We are being told to explicitly lint
Expand All @@ -86,18 +86,20 @@ Argument EXTRA-ARGS: passes extra args to the checker."

;; Else use the mode to infer which language to turn on.
(pcase ,lang
("clj" `(equal 'clojure-mode major-mode))
("cljs" `(equal 'clojurescript-mode major-mode))
("cljc" `(equal 'clojurec-mode major-mode)))))))
("clj" (member major-mode '(clojure-mode clojure-ts-mode)))
("cljs" (member major-mode '(clojurescript-mode clojurescritps-ts-mode)))
("cljc" (member major-mode '(clojurec-mode clojurec-ts-mode))))))))

Comment thread
borkdude marked this conversation as resolved.
;; (macroexpand-1 '(flycheck-clj-kondo--define-checker clj-kondo-clj "clj" clojure-mode "--cache"))

(defmacro flycheck-clj-kondo-define-checkers (&rest extra-args)
"Defines all clj-kondo checkers.
Argument EXTRA-ARGS: passes extra arguments to the checkers."
`(progn
(flycheck-clj-kondo--define-checker clj-kondo-clj "clj" clojure-mode ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-cljs "cljs" clojurescript-mode ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-cljc "cljc" clojurec-mode ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-edn "edn" clojure-mode ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-clj "clj" (clojure-mode clojure-ts-mode) ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-cljs "cljs" (clojurescript-mode clojurescritps-ts-mode) ,@extra-args)
Comment thread
borkdude marked this conversation as resolved.
Outdated
(flycheck-clj-kondo--define-checker clj-kondo-cljc "cljc" (clojurec-mode clojurec-ts-mode) ,@extra-args)
(flycheck-clj-kondo--define-checker clj-kondo-edn "edn" (clojure-mode clojure-ts-mode) ,@extra-args)
(dolist (element '(clj-kondo-clj clj-kondo-cljs clj-kondo-cljc clj-kondo-edn))
(add-to-list 'flycheck-checkers element))))

Expand Down