Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --rm flag to default docker run command #222

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Add --rm flag to default docker run command #222

merged 1 commit into from
Jun 11, 2022

Conversation

AetherUnbound
Copy link
Contributor

Another small PR to ensure that the docker container cleans up after itself when run using run_docker_image.sh.

@borisdayma
Copy link
Owner

borisdayma commented Jun 11, 2022 •
edited
Loading

Thanks!
I don't use much docker so I'll leave it open to see if there's any comment and will merge in 1-2 days

patrickpiccini
patrickpiccini approved these changes Jun 11, 2022
View reviewed changes
Copy link
Contributor

@patrickpiccini patrickpiccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really is a good practice not to accumulate obsolete containers

@borisdayma
Copy link
Owner

Thanks a lot!

@borisdayma borisdayma merged commit 466a6b6 into borisdayma:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickpiccini patrickpiccini patrickpiccini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AetherUnbound @borisdayma @patrickpiccini