Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerfile #191

Merged
merged 2 commits into from
May 30, 2022
Merged

feat: dockerfile #191

merged 2 commits into from
May 30, 2022

Conversation

batrlatom
Copy link
Contributor

No description provided.

Docker/Dockerfile Outdated Show resolved Hide resolved
Copy link

@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FROM nvidia/cuda:11.6.2-cudnn8-devel-ubuntu20.04

RUN apt-get update && apt-get install -y \
  git \
  python3 \
  python3-pip \
  && rm -rf /var/lib/apt/lists/*

RUN pip install --upgrade "jax[cuda]" -f https://storage.googleapis.com/jax-releases/jax_releases.html \
  && pip install -q \
  git+https://github.com/borisdayma/dalle-mini.git \
  git+https://github.com/patil-suraj/vqgan-jax.git

WORKDIR /workspace

Use dockerfile best practices: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get

Co-authored-by: Adam Stachowicz <[email protected]>
@borisdayma
Copy link
Owner

Many thanks!
Is it ready to be merged?

@Saibamen
Copy link

Saibamen commented May 23, 2022

Should be tested first (screenshots IMO is must have)

I still don't know what this image should do. There is no ENTRYPOINT...

@batrlatom
Copy link
Contributor Author

batrlatom commented May 24, 2022

The dockerfile was intented to be just environment for development and inference. If you want to have for example gradio or streamlit app to be run after the start, I can make it so.

@Saibamen
Copy link

@borisdayma
Copy link
Owner

I think it's a great start! Many thanks for this 🔥
I'm gonna merge it and we can always iterate building specific files for certain uses.

@borisdayma borisdayma merged commit 21944e2 into borisdayma:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants