Remove duplicate sources on profile import #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3nu
reviewed
Jun 7, 2024
src/vorta/profile_export.py
Outdated
| @@ -130,6 +130,9 @@ def to_db(self, overwrite_profile=False, overwrite_settings=True): | |||
| # Set the profile ids to be match new profile | |||
| for source in self._profile_dict['SourceFileModel']: | |||
| source['profile'] = self.id | |||
| # Delete existing Sources to avoid duplicates | |||
| for source in SourceFileModel.select().where(SourceFileModel.profile == self.id): | |||
There was a problem hiding this comment.
You don't need a loop here. Can be done with one query. E.g.
m3nu
approved these changes
Jul 1, 2024
|
Thanks, I will give it a try, once released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes duplicate source files when importing an existing profile and choosing to overwrite. Based on PR by @TheLazron .
Related Issue
Fixes #1942
Motivation and Context
How Has This Been Tested?
Tested locally.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.