Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress for currently selected Profile #1960

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheLazron
Copy link
Contributor

Description

Functions used to log the progress, check for the selected profile, before rendering them

Related Issue

#1824

Motivation and Context

Improves user experience by filtering the progress logged

How Has This Been Tested?

Scheduling backups for multiple profiles, but logs and progress for only selected profile is shown

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!


def set_log(self, text=''):
self.logText.setText(text)
self.logText.repaint()
profile = extract_profile_name(text)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you modify the log signal similar to the progress signal. We shouldn't inexplicitely expect a specific log message format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants