Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deadlock when calling subprocess.Popen() #194

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Feb 16, 2019

This (hopefully) avoids the deadlock situation mentioned in the Python docs and this SO question:

The preexec_fn parameter is not safe to use in the presence of threads in your application. The child process could deadlock before exec is called. If you must use it, keep it trivial! Minimize the number of libraries you call into.

In addition it avoids getting the details of terminated Borg processes when looking for mount points. Discussed here.

@m3nu m3nu merged commit b23cdf9 into borgbase:master Feb 20, 2019
@m3nu m3nu deleted the issue/187/hanging-subprocess branch January 20, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant