Notifications improvement. #1522
Conversation
* src/vorta/notifications.py (DBusNotifications._dbus_notify): Cleanup code. Use colourful icon for notifcations. * Makefile (flatpack-install): Don't copy symbolic app icon.
* src/vorta/notifications.py (DBusNotifications): Rename `_dbus_notify` to `_notify`. * src/vorta/notifications.py (DBusNotifications): Add `close`. * src/vorta/notifications.py (DBusNotifications): Add `__init__` retrieving server capabilities. * src/vorta/notifications.py (DBusNotifications): Extend capabilities of `_notify` with actions and more.
* setup.cfg (options.install_requires): Add requirement `pyobjc-framework-UserNotifications`. * src/vorta/notifications.py : Implement MacOS notifications. * src/vorta/notifications.py (DBusNotifications): Refactor. * src/vorta/application.py : Create one notification instance on launch and use this instance to deliver notifications. * src/vorta/scheduler.py * src/vorta/views/export_window.py * src/vorta/views/main_window.py : Use the global notification instance.
real-yfprojects
force-pushed
the
kde-notifications-icon
branch
from
f21e737
to
28ffe87
Compare
I also checked XFCE. Works and looks very similar to GNOME. |
|
@m3nu Have you got time for this in the near future? Or should I exclude the MacOS changes from this PR? |
|
Nice rewrite. Will work on it for macOS of course. |
|
Fixed up macOS notifications to the point where they don't cause an error and open the main window when clicked. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
real-yfprojects
added
help wanted
|
This is definitely still needed - #1773 |
|
Yeah, the Linux part is all done, but the MacOS code needs to be tested and completed. I can't do that because I dont have MacOS. |
Closes #609.
I went a bit overboard and reimplemented the notifications module. It now supports the full
org.freedesktop.Notificationsfeature set and uses the new MacOSUserNotificationsAPI. The symbolic icon added in #563 is removed because notifications use the normal app icon afaik.It would be a miracle if the MacOS code worked. Testing and fixing it is up to you.
The linux code works as expected: