Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --timestamp in placeholders if given (1.1 backport) #5488

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

milkey-mouse
Copy link
Contributor

See #5189, #5472.

@ThomasWaldmann
Copy link
Member

py35 tests failing.

@milkey-mouse
Copy link
Contributor Author

milkey-mouse commented Nov 5, 2020

Ah, this is because astimezone only works on naive objects as of 3.6.

Is there a good reason --timestamp is limited to UTC in the first place? Currently the timestamp, whether given directly or via a file, is a naive datetime. IMO the "best" way to solve this issue is to make them timezone aware.

@ThomasWaldmann
Copy link
Member

I can't help with that, please find out in the code yourself.

I just want it to be consistent, so implement dealing with timezones in the same way as the code is doing it right now.

@milkey-mouse
Copy link
Contributor Author

I was mostly thinking out loud. TL;DR it works correctly, such that {now} is different from {utcnow} with --timestamp (if you're not in UTC timezone).

@ThomasWaldmann ThomasWaldmann merged commit d658fd7 into borgbackup:1.1-maint Nov 6, 2020
@ThomasWaldmann
Copy link
Member

Thanks for the PR. For remaining issues / ideas, please open a ticket.

@milkey-mouse milkey-mouse deleted the bp-5472 branch November 6, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants