-
-
Notifications
You must be signed in to change notification settings - Fork 344
Write only db #234
base: master
Are you sure you want to change the base?
Write only db #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
@lruggieri When I said that it must be proposed to the upstream I also mentioned change segregation. I meant that my changes adding beanstalkd support must not be included in such PR. So I think it'd be better to rebase this PR to only implement this interface for This way if @boramalper want to merge your changes and don't want to merge mine it is possible for him to do that. Someone correct me if I'm wrong. BTW I like the idea of second interface for write-only engines so we don't need to implement methods which we don't need in such implementations. |
ca27bc8
to
c89041c
Compare
Yes. Now that's more like what I've suggested earlier. I'm not sure about the code though. Leaving this to @boramalper who knows Go far better than me. |
@skobkin makes sense, even if it is will be a bit long and I am starting to have a bit too many branches on my fork xD |
You can do what I did. I've just merged all I need for my project to the separate branch and building Docker images from there. But each feature is also in the separate branch which makes it simpler to review or merge for upstream maintainer.
As I said earlier I have some doubts about the code itself. But I'm not Go expert and do not own this project. So it'd be better for Bora to do code review. Regarding change/feature separation I think everything is fine now. |
Adding interface for write-only type DBs. This adds to @skobkin Beanstalk engine implementation.