The keyboard devices are now getting automatically recognized and don't raise OSError when disconected #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusbalbino1
approved these changes
Mar 17, 2024
ophmar13
reviewed
Apr 8, 2024
… too much resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the devices are disconected on Linux based systems it caused the OSError and made the program crash. Now the AggregatedEventDevice automatically creates a thread which checks if there are any new devices that have been added. It also recognises if the device has been removed and closes the thread that listened to that device's inputs. Issues:
#531
#639