Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-slide chokes on 4th-level headings #2095

Open
2 tasks done
schanzer opened this issue Jun 23, 2024 · 2 comments
Open
2 tasks done

build-slide chokes on 4th-level headings #2095

schanzer opened this issue Jun 23, 2024 · 2 comments
Assignees

Comments

@schanzer
Copy link
Member

schanzer commented Jun 23, 2024

We almost never use them outside of some recent changes to Algebra 2, so it's no surprise this hasn't come up before.

In exploring-linear-models, the content around 4th level headers just doesn't show up in zlides.md.

  • These headers should be ignored by slides altogether
  • Once done, ES needs to bring them back to the Alg2 lessons.
@schanzer schanzer added this to the July 1, 2024 milestone Jun 23, 2024
schanzer pushed a commit that referenced this issue Jul 7, 2024
- Bring back all 4th level headings (see #2095)
- Add more 4th level headings so that coefficients in each non-linear model are introduced the same way
- Add a strategy box for the model-fitting game in each unit
@flannery-denny
Copy link
Collaborator

@ds26gte

  • In @schanzer's spec it says "4th-level headers should be ignored by slides all together"
  • Your commit it titled "==== sections should become @slidebreaks"

Having read @schanzer's spec I inserted slidebreaks where I needed them in the box-plots lesson. When I built slides I got synthesize templates in the launch section.

I have resolved the issue in the deck I was working on by proscribing the template with each slidebreak, but this is a tricky thing for authors to catch. please update lua so that ==== are ignored by slides so that authors can decide where to break slides and we end up with slides templates that correspond to the lesson section we're authoring in.

@flannery-denny
Copy link
Collaborator

@ds26gte Noting that even with @slidebreak{LaunchC} on line 279 of the lesson plan I had to manually go select the correct template in google drive for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants