Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve CSS on WeScheme #585

Closed
2 tasks done
schanzer opened this issue Nov 16, 2021 · 1 comment
Closed
2 tasks done

Resolve CSS on WeScheme #585

schanzer opened this issue Nov 16, 2021 · 1 comment
Assignees
@schanzer
Labels
bug
Milestone
alpha

Comments

@schanzer
Copy link
Member

schanzer commented Nov 16, 2021 •
edited
Loading

There's some predefined CSS rules that are stomping on CMB.

  • modify WeScheme to prevent this
  • more importantly, strengthen the CSS rules in CMB to make the library more resilient against integration issues like this
@schanzer schanzer added the bug label Nov 16, 2021
@schanzer schanzer added this to the alpha milestone Nov 16, 2021
@schanzer schanzer self-assigned this Nov 16, 2021
@pcardune
Copy link
Collaborator

The second part is related to #509

schanzer pushed a commit that referenced this issue Nov 22, 2021
make codemirror-pane dimensions more robust (see #585)
2b070c7
schanzer pushed a commit that referenced this issue Nov 24, 2021
make codemirror-pane dimensions more robust (see #585) (#604)
6c82793 
* make codemirror-pane dimensions more robust (see #585)

* remove unnecessary rule, which also causes some problems in corner cases

* finally tracked down weird ghost borders

* jsPrettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schanzer schanzer

Labels
bug
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
2 participants
@schanzer @pcardune