Make description and created optional in push_layer_full method #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building reproducible images we don't want the `created` field. Signed-off-by: Etienne Champetier <[email protected]>
Collaborator
Author
|
@cgwalters any opinion on this one ? I can create a new api if prefered, I was just not inspired for the name |
cgwalters
added a commit
that referenced
this pull request
Jun 2, 2025
This allows convenient control over all parts of the history, including the timestamp. Replaces #36 Related to bootc-dev/bootc#1339 Signed-off-by: Colin Walters <[email protected]>
Collaborator
|
I did #37 which avoids breaking semver and I think does what we need here, and is more generally powerful |
cgwalters
added a commit
that referenced
this pull request
Jun 2, 2025
This allows convenient control over all parts of the history, including the timestamp. Replaces #36 Related to bootc-dev/bootc#1339 Signed-off-by: Colin Walters <[email protected]>
cgwalters
added a commit
that referenced
this pull request
Jun 2, 2025
This allows convenient control over all parts of the history, including the timestamp. Replaces #36 Related to bootc-dev/bootc#1339 Signed-off-by: Colin Walters <[email protected]>
cgwalters
added a commit
that referenced
this pull request
Jun 2, 2025
This allows convenient control over all parts of the history, including the timestamp. Replaces #36 Related to bootc-dev/bootc#1339 Signed-off-by: Colin Walters <[email protected]>
Collaborator
Author
|
Closing in favor of #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building reproducible images we don't want the
createdfield.Related to bootc-dev/bootc#1339