build-sys: Various cleanups, doc clarification #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First change `.dockerignore` to be an allowlist. This avoids spurious rebuilds when touching e.g. `tmt/`, and also crucially we don't leak `.git/` into the sources which can easily change as one makes commits/branches. This also requires touching the `hack/` directory which is now fully self contained. While we're here, make clear the roles of Justfile vs Makefile. Remove the `make test`. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several cleanups to the build system. The .dockerignore file is changed to an allowlist, which is a good practice to prevent accidentally including unwanted files. The roles of Justfile and Makefile are clarified with comments, and an unused make test target is removed. The hack/Containerfile is refactored to be more self-contained and to improve build caching by using multiple stages. My review includes a suggestion to improve the Docker layer caching strategy in hack/Containerfile to make it more effective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change
.dockerignoreto be an allowlist.This avoids spurious rebuilds when touching e.g.
tmt/, and also crucially we don't leak.git/into the sources which can easily change as one makes commits/branches.This also requires touching the
hack/directory which is now fully self contained.While we're here, make clear the roles of Justfile vs Makefile. Remove the
make test.