cfs: only get sysroot storage when repo is not supplied #1581
Conversation
For image building, we want to be able to run this on a non-bootc host or in a container. There we'll manipulate the composefs repo in a provided tempdir. Signed-off-by: John Eckersberg <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the cfsctl command handling to conditionally initialize the system storage. Previously, the storage was initialized unconditionally at the call site in cli.rs. Now, the initialization is deferred to cfsctl::run_from_iter and only occurs when a system repository is needed (i.e., when a specific repository path is not provided via command-line arguments). This change correctly aligns with the goal of allowing cfsctl to be used in environments without a bootc-managed sysroot, such as for image building. The changes are logical, improve code organization by making cfsctl more self-contained, and appear to be correctly implemented. I have no specific feedback or suggestions for improvement.
2 participants
For image building, we want to be able to run this on a non-bootc host
or in a container. There we'll manipulate the composefs repo in a
provided tempdir.
Signed-off-by: John Eckersberg [email protected]