Makefile: Create storage symlink as relative #1577
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly changes the creation of the storage symlink from an absolute path to a relative one, which improves the relocatability of the installed package. The use of realpath to compute the relative path for the final system (ignoring DESTDIR) is the correct approach. I've added a couple of suggestions to quote path variables to make the Makefile more robust against paths containing spaces.
jeckersb
force-pushed
the
storage-relative-path
branch
from
64d42cf to
7099d1b
Compare
Resolves: bootc-dev#1575 Signed-off-by: John Eckersberg <[email protected]>
jeckersb
force-pushed
the
storage-relative-path
branch
from
7099d1b to
5d49775
Compare
|
Hm this seems to have tripped up a downstream rpm linter 
Looking... |
|
Hum maybe what we should do here actually is make it a mount point... Or maybe we teach container-libs how to support AIS aliases |
|
Nah I think this is all fine, it's just that it doesn't like dangling links, which I get...but hard to fix. |
2 participants
Resolves: #1575
Signed-off-by: John Eckersberg [email protected]