initramfs: Better error handling #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly improves error handling by introducing fn-error-context and applying it throughout the mount logic. The use of #[context] attributes and context-aware wrappers makes error messages much more informative and easier to trace. This is a great enhancement for debuggability. I have one major point of feedback regarding a logic change that seems unrelated to error handling and should be clarified.
cgwalters
approved these changes
Aug 28, 2025
Add error contexts to functions. Create wrappers around intrenal functions with error context added Signed-off-by: Johan-Liebert1 <[email protected]>
This is prep work for eventual integration with composefs-native backend Signed-off-by: Johan-Liebert1 <[email protected]>
Johan-Liebert1
force-pushed
the
composefs-initramfs-error-handling
branch
from
a66ca6b to
5cbc0be
Compare
Collaborator
Author
|
Moved the change to a separate commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error contexts to functions. Create wrappers around intrenal functions with error context added.
Also make
/etca bind mount