Skip to content

sysroot: Log locking to stderr, not stdout #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

sysroot: Log locking to stderr, not stdout #1535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ostree-ext/src/sysroot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ impl SysrootLock {
});
}
if !printed {
println!("Waiting for sysroot lock...");
eprintln!("Waiting for sysroot lock...");
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using eprintln! is a good step to avoid polluting stdout, it would be more idiomatic and maintainable to use a structured logging facade like the log crate (e.g., log::info!("Waiting for sysroot lock...")). This aligns with the goal of auditing println! usage mentioned in the PR description and allows for benefits like configurable log levels.

As a side note, the doc comment for new_from_sysroot on line 35 is now outdated and should be updated to state that the message is printed to standard error.

printed = true;
}
tokio::time::sleep(std::time::Duration::from_secs(3)).await;
Expand Down