Write nom parser for Grub menuentries #1480
Merged
+535
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
cgwalters
commented
Aug 1, 2025
|
|
||
| [features] | ||
| default = ["install-to-disk"] | ||
| default = ["install-to-disk", "grub"] |
Collaborator
Author
There was a problem hiding this comment.
@Johan-Liebert1 note I made this an opt-outable feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a nom-based parser for GRUB menuentry files, adding nom as a dependency and gating the new functionality behind a grub feature flag. The implementation is a good start, but there are several areas for improvement. My review includes suggestions to enhance error reporting, fix a bug in parsing quoted strings, improve code clarity and style by removing unused code and adhering to Rust idioms, and adjust visibility for better encapsulation. These changes will make the parser more robust and maintainable.
cgwalters
force-pushed
the
composefs-prep-grub
branch
from
324c322 to
e8d9f9a
Compare
This will be needed in some scenarios for composefs. Assisted-by: Claude Code Signed-off-by: Johan-Liebert1 <[email protected]> Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
composefs-prep-grub
branch
from
e8d9f9a to
3548a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.