Skip to content

Conversation

@imbev
Copy link
Contributor

@imbev imbev commented Jul 29, 2025

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the ADOPTERS.md file to reclassify HeliumOS from an 'End-User' to a 'Vendor'. This change aligns with the definitions provided within the document. I have added one suggestion to improve the consistency of the table by sorting the entries alphabetically now that multiple entries of the same type and year exist.

|:-|:-|:-|:-|:-|
Vendor | Red Hat | 2024 | https://redhat.com | Image Based Linux
End-User | HeliumOS | 2024 | https://www.heliumos.org/ | An atomic desktop operating system for your devices
Vendor | HeliumOS | 2024 | https://www.heliumos.org/ | An atomic desktop operating system for your devices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that both this entry and the one for Red Hat are of type Vendor and from the same year, it would be beneficial for consistency to sort them alphabetically by name. This would place HeliumOS before Red Hat. The other table in this file appears to be sorted by year, and for entries with the same year, alphabetical sorting by name would be a good secondary sorting criterion.

Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit d35d235 into bootc-dev:main Jul 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants