-
Notifications
You must be signed in to change notification settings - Fork 144
Move all crates under crates/
#1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1307809 to
b2c455c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the project structure by moving all crates into a crates/ subdirectory and updating the workspace Cargo.toml to use a glob for discovering members. My review identified a high-severity issue where readme paths in the individual crates' Cargo.toml files were not updated after the move, which could break documentation and packaging.
b2c455c to
2aedb33
Compare
5b6fee0 to
757f987
Compare
|
Note to self and others, run |
757f987 to
8e0c772
Compare
8e0c772 to
5fd342e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pushed one minor fix that was erroring in CI. Assuming everything passes, ship it!
5fd342e to
bc7096e
Compare
|
Manually rebased, not sure why github was claiming there was conflicts because it rebased just fine 🤷 |
bc7096e to
1943cfb
Compare
|
Hm I think you pushed over my fixup Edit: to be more specific: |
1943cfb to
5e4116c
Compare
|
Thanks! Yes I messed that up, I think I fetched from my branch but forgot to actually reset my local to the remote. Should be fixed now |
We don't actually publish any of these so there's no need for this.
Just organizational cleanup, a number of Rust projects do this: https://github.com/search?q=+%22crates%2F*%22+path%3ACargo.toml+-is%3Afork&type=code&p=5 Signed-off-by: Colin Walters <[email protected]>
5e4116c to
2f69a16
Compare
|
Hmm Github seems to be treating any modifications to a renamed file as a conflict, when the git client definitely is happy to just do the obvious thing and update the new name. |
Just organizational cleanup, a number of Rust projects do this:
https://github.com/search?q=+%22crates%2F*%22+path%3ACargo.toml+-is%3Afork&type=code&p=5