Skip to content

Conversation

@ckyrouac
Copy link
Collaborator

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of bootc-lib to 1.5.0 for a new release. The changes in Cargo.lock and lib/Cargo.toml are correct. However, I've noticed that the version number seems to be hardcoded in several documentation files and hasn't been updated. Please see my comment for details.

# The intention is we'll follow semver here, even though this
# project isn't actually published as a crate.
version = "1.4.0"
version = "1.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the crate version is correctly updated here, the version number appears to be hardcoded in the man pages and has not been updated to 1.5.0. This can lead to confusion for users reading the documentation.

The following files still reference v1.4.0:

  • docs/src/man/bootc.md
  • docs/src/man/bootc-upgrade.md
  • docs/src/man/bootc-install.md
  • docs/src/man/bootc-rollback.md
  • docs/src/man/bootc-switch.md
  • docs/src/man/bootc-status.md

Please update these files to reflect the new version. To prevent this from being missed in future releases, you might consider automating this update as part of your release process.

Signed-off-by: ckyrouac <[email protected]>
@ckyrouac ckyrouac merged commit b290ad2 into bootc-dev:main Jul 16, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants