Skip to content

Conversation

@jmarrero
Copy link
Contributor

@jmarrero jmarrero commented Jul 8, 2025

Add --verbose/-v to bootc status similar to rpm-ostree status --verbose

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a --verbose flag to the bootc status command to display more detailed information. The implementation correctly adds the CLI flag and passes it to the output generation. The review suggests reducing code duplication.

Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@jmarrero
Copy link
Contributor Author

jmarrero commented Jul 9, 2025

[core@cosa-devsh ~]$ sudo bootc status
● Booted ostree
           Commit: f1e8b71e96b9b9419e3f84e010ff9f82f6db28f74bd5eda6eb4008fcb8934fd4
[core@cosa-devsh ~]$ sudo bootc status -v
● Booted ostree
           Commit: f1e8b71e96b9b9419e3f84e010ff9f82f6db28f74bd5eda6eb4008fcb8934fd4
        StateRoot: fedora-coreos
    Deploy serial: 0
           Staged: no

With a staged deployment

[core@cosa-devsh ~]$ sudo bootc status --verbose
  Staged ostree
         Commit: f1e8b71e96b9b9419e3f84e010ff9f82f6db28f74bd5eda6eb4008fcb8934fd4
      StateRoot: fedora-coreos
  Deploy serial: 1
         Staged: yes

● Booted ostree
           Commit: f1e8b71e96b9b9419e3f84e010ff9f82f6db28f74bd5eda6eb4008fcb8934fd4
        StateRoot: fedora-coreos
    Deploy serial: 0
           Staged: no

@jmarrero jmarrero marked this pull request as ready for review July 9, 2025 20:37
@cgwalters cgwalters enabled auto-merge July 9, 2025 21:00
@cgwalters cgwalters merged commit 5ed53c3 into bootc-dev:main Jul 9, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants