Skip to content

Conversation

@cgwalters
Copy link
Collaborator

  • Note the existence of /run here
  • Describe how to use podman login --authfile to write it
  • Also describe the pattern of symlinking to keep things in sync where desired

@github-actions github-actions bot added documentation control/skip-ci Do not run expensive CI on this job labels Jun 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the documentation for secrets management by adding details about using /run/ostree/auth.json, synchronizing credentials with podman, and using podman login --authfile. The new information is clear and helpful for users. I've made a couple of suggestions to correct typos in the command examples to improve accuracy and usability.

- Note the existence of `/run` here
- Describe how to use `podman login --authfile` to write it
- Also describe the pattern of symlinking to keep things in sync
  where desired

Signed-off-by: Colin Walters <[email protected]>
Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit a931215 into bootc-dev:main Jul 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

control/skip-ci Do not run expensive CI on this job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants