Bump to newer ocidir and containers-image-proxy #1377
Conversation
Mostly just keeping up with things, but this is also prep for us using `GetRawBlob`. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request bumps the versions of ocidir and containers-image-proxy. There are several instances where error handling could be improved by explicitly handling the result of functions like read_index and new_empty_manifest instead of unwrapping them. Additionally, adding comments to explain the use of try_clone() would improve code clarity.
| )?; | ||
|
|
||
| let mut manifest = ocidir::new_empty_manifest().build().unwrap(); | ||
| let mut manifest = writer.new_empty_manifest()?.build().unwrap(); |
There was a problem hiding this comment.
Consider handling the error case where new_empty_manifest fails. Currently, it's unwrapped, which could lead to unexpected program termination.
| let mut manifest = writer.new_empty_manifest()?.build().unwrap(); | |
| let mut manifest = writer.new_empty_manifest()?; |
| let idx = tempsrc | ||
| .read_index()? | ||
| .ok_or(anyhow!("Reading image index from source"))?; | ||
| let idx = tempsrc.read_index()?; |
There was a problem hiding this comment.
Consider handling the error case where read_index fails. Currently, the error is not handled, which could lead to unexpected program termination.
| let idx = tempsrc.read_index()?; | |
| let idx = tempsrc.read_index()?; |
There was a problem hiding this comment.
Gemini is apparently just confused by us dropping a ?, clearly the error is still handled
|
|
||
| let mut config = ImageConfigurationBuilder::default().build().unwrap(); | ||
| let mut manifest = ocidir::new_empty_manifest().build().unwrap(); | ||
| let mut manifest = self.src_oci.new_empty_manifest()?.build().unwrap(); |
There was a problem hiding this comment.
Consider handling the error case where new_empty_manifest fails. Currently, it's unwrapped, which could lead to unexpected program termination.
| let mut manifest = self.src_oci.new_empty_manifest()?.build().unwrap(); | |
| let mut manifest = self.src_oci.new_empty_manifest()?; |
| self.src_oci | ||
| .replace_with_single_manifest(manifest, oci_image::Platform::default())?; | ||
| let idx = self.src_oci.read_index()?.unwrap(); | ||
| let idx = self.src_oci.read_index()?; |
There was a problem hiding this comment.
Consider handling the error case where read_index fails. Currently, the error is not handled, which could lead to unexpected program termination.
| let idx = self.src_oci.read_index()?; | |
| let idx = self.src_oci.read_index()?; |
2 participants
Mostly just keeping up with things, but this is also prep for us using
GetRawBlob.