Skip to content

Conversation

@jeckersb
Copy link
Collaborator

Signed-off-by: John Eckersberg [email protected]

Signed-off-by: John Eckersberg <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the bootc-lib crate from 1.3.0 to 1.4.0 in lib/Cargo.toml and consequently in Cargo.lock. These changes are consistent with the PR title "Release 1.4.0" and appear correct for a version bump.

For future consideration to enhance clarity and maintainability (medium severity): the cli crate's Cargo.toml (located at cli/Cargo.toml, which is not part of this PR's changes) declares its dependency on bootc-lib with version = "1.0" (i.e., bootc-lib = { version = "1.0", path = "../lib" }). While Cargo correctly resolves path dependencies to use the actual version from the local path (1.4.0 after this PR), having this declared version differ significantly from bootc-lib's actual version could be confusing for developers. Aligning this declared version (e.g., to "1.4.0"), or using a common placeholder like "*" or "=1.4.0" for path dependencies, might improve consistency. Since bootc-lib is not published to crates.io (as noted by a comment in lib/Cargo.toml) and the cli crate also has publish = false, this is not a functional issue but a point of potential minor confusion.

@cgwalters cgwalters merged commit 58ee28c into bootc-dev:main Jun 16, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants