ostree-ext: Add tar_create_parent_dirs to container::ExportOpts #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner fn In preparation for (un)mapping tar stream data back to ostree data so we can look up the correct metadata for a given tar entry
…o use `as_os_str()`
We want to compare the actual os_str here, because `Eq` on Paths
canonicalizes and removes any trailing '/', but ostree makes a
distinction between trailing '/' or not. For example:
```
let p1 = Path::new("/foo");
let p2 = Path::new("/foo/");
assert_eq!(p1, p2);
println!("{:?} {:?}", p1.as_os_str(), p2.as_os_str());
```
Will print:
"/foo" "/foo/"
Signed-off-by: John Eckersberg <[email protected]>
Part of coreos/rpm-ostree#5416 Default to previous behavior and do *not* create parent directories, however for reproducible builds we need to ensure we create them with consistent metadata. See also containers/composefs-rs#132 Signed-off-by: John Eckersberg <[email protected]>
jeckersb
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
jeckersb
added a commit
to jeckersb/rpm-ostree
that referenced
this pull request
Jun 12, 2025
Primarily to pull in bootc-dev/bootc#1364 Signed-off-by: John Eckersberg <[email protected]>
jeckersb
added a commit
to jeckersb/rpm-ostree
that referenced
this pull request
Jun 16, 2025
Primarily to pull in bootc-dev/bootc#1364 Signed-off-by: John Eckersberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_os_str()tar_create_parent_dirstocontainer::ExportOpts