kargs: Clarify a bit more #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes via `rpm-ostree kargs` will persist, this came up as a question - Explicitly mention the `unshare -m` trick - Emphasize a bit more bootc+rpm-ostree do interoperate; except for removing things added by `/usr/lib/bootc/kargs.d`, don't do that
github-actions
bot
added
documentation
control/skip-ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the kernel arguments documentation to clarify several important aspects: the persistence of changes made by rpm-ostree kargs, a method for editing /boot using unshare -m, the interoperability of bootc and rpm-ostree, and a critical warning against modifying base image kernel arguments. The changes significantly improve the documentation's utility. My review includes a few suggestions to further enhance readability and the impact of key warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpm-ostree kargswill persist, this came up as a questionunshare -mtrick/usr/lib/bootc/kargs.d, don't do that