Skip to content

Conversation

@ckyrouac
Copy link
Collaborator

@ckyrouac ckyrouac commented Jun 3, 2025

No description provided.

@github-actions github-actions bot added documentation control/skip-ci Do not run expensive CI on this job labels Jun 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the documentation for bootc-install.md by clarifying two important aspects of the reinstall process:

  1. Handling of previous mount points/subvolumes: The documentation now explicitly states that while data on previous mount points (like a /home btrfs subvolume) persists after a reinstall, these are not automatically mounted into the new system under /sysroot. It correctly guides users that these need to be handled either by manual mounting or by defining the mount points within the bootc image itself. This is a crucial piece of information for users to avoid confusion about missing home directories or other data post-reinstall.
  2. Introduction of the cleanup service: The documentation for system-reinstall-bootc now includes details about the bootc-destructive-cleanup.service. It explains that this service runs on the first boot to clean up parts of the previous system and helpfully links to an example Fedora script, illustrating how these cleanup actions can be customized per distribution.

Overall, these additions are clear, concise, and significantly improve the user's understanding of what to expect and how to manage their system during and after a reinstall. The changes are well-written and directly address potential user pain points. Great work on improving the documentation!

Summary of Findings

  • Minor stylistic suggestion for mount point documentation: In docs/src/bootc-install.md, line 226, the phrase "any way you want like manually mounting them" could be slightly more formal. A suggestion would be "in various ways, such as manually mounting them" or "in several ways, for example, by manually mounting them". This is a minor point of style (severity: low), and no specific review comment was added due to the project's review settings for comment severity.

Merge Readiness

The documentation changes in this pull request are clear, accurate, and add valuable information for users. There are no critical or high-severity issues. I believe this PR is in good shape and ready for merging. As an AI, I am not authorized to approve pull requests, so please ensure it undergoes the standard review and approval process by other maintainers.

Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

is the "physical root").

However, previous mount points or subvolumes will not be automatically
mounted in the new system, e.g. a btrfs subvolume for /home will not be automatically mounted to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit for the future, let's use code blocks like /home

@cgwalters cgwalters merged commit 5abda6a into bootc-dev:main Jun 3, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

control/skip-ci Do not run expensive CI on this job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants