install: Fallback to no sepolicy when init imgstore #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the policy csum to make sure there is actually a policy available to lookup when trying to label the bootc container storage. Fixes bootc-dev#1303 Signed-off-by: ckyrouac <[email protected]>
cgwalters
approved these changes
May 15, 2025
There was a problem hiding this comment.
Thanks!
I do feel like this is a bug probably in the ostree sepolicy code. It'd feel better to just return None in this case probably?
But...mmm...I think I have a vague memory now that the reason it's this way is historical because I in C code it was convenient to just pass around a *OstreeSepolicy and not always check it for null or something?
Comment on lines
+107
to
+111
| let sepolicy = if sepolicy.csum().is_none() { | ||
| None | ||
| } else { | ||
| Some(sepolicy) | ||
| }; |
There was a problem hiding this comment.
This is also let sepolicy = sepolicy.filter(|policy| policy.csum.is_some()); too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the policy csum to make sure there is actually a policy available to lookup when trying to label the bootc container storage.
Fixes #1303