internals: Add new (experimental) bootc internals fsck#1178
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Mar 13, 2025
Merged
internals: Add new (experimental) bootc internals fsck#1178cgwalters merged 1 commit intobootc-dev:mainfrom
bootc internals fsck#1178cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
This was referenced Mar 7, 2025
cgwalters
changed the title
bootc internals fsckbootc internals fsck
jeckersb
approved these changes
Mar 7, 2025
Collaborator
jeckersb
left a comment
jeckersb
left a comment
There was a problem hiding this comment.
LGTM, just one nit about the header that is not a blocker
Split this out of the fsverity PR. We obviously want a `fsck` command. This starts by doing just two checks: - A verification of `etc/resolv.conf`; this tests bootc-dev@98995f6 - Just run `ostree fsck` But obvious things we should be adding here are: - Verifying kargs - Verifying LBIs etc. Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
|
Hmm hit the |
Collaborator
Author
|
I tweaked this one a bit because I ended up wanting to use tokio as a threadpool, and so I made the main fsck entrypoint |
Collaborator
Author
|
/packit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split this out of the fsverity PR.
We obviously want a
fsckcommand. This starts by doing just two checks:etc/resolv.conf; this tests 98995f6ostree fsckBut obvious things we should be adding here are:
etc.