Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost::variant_alternative<size_t I, boost::variant<Types...>> implem… #37

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

boost::variant_alternative<size_t I, boost::variant<Types...>> implem… #37

wants to merge 1 commit into from

Conversation

very-cool-name
Copy link
Contributor

…entation. Uses variadic templates for modern compilers and boost::mpl magic for older ones. Tested on gcc 4.9.3, 6.3.0 and msvc 14.1. I'll add documentation little bit later.

@very-cool-name
boost::variant_alternative<size_t I, boost::variant<Types...>> implem…
1922562 
…entation. Uses variadic templates for modern compilers and boost::mpl magic for older ones.
@apolukhin
Copy link
Member

I'm afraid this won't work for variants that were created using make_variant_over. I'm also not sure that this will work for variants that hold a reference type.

Please add more tests.

@very-cool-name
Copy link
Contributor Author

There is test for make_variant_over it is called test_over_sequence_type. Is it insufficient? I'll add tests for reference types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@very-cool-name @apolukhin