Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use std::function if c++11 <functional> is available #115

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WIP: use std::function if c++11 <functional> is available #115

wants to merge 1 commit into from

Conversation

jhunold
Copy link
Contributor

@jhunold jhunold commented Apr 7, 2017

All except one test green.
test-tree-management-test is failing as somehow the conversion or more
exactly the display of std::function is not working as expected in
BOOST_TEST( tc1->p_test_func ); in line 118
Tested c++03 compatibility with gcc-6.2 in c++03 mode

@raffienficiaud
Copy link
Member

Hi, thanks for the PR. I fail to understand why should we move to std::function, is there any rationale? doesn't boost::function do the job?

@jhunold
Copy link
Contributor Author

jhunold commented May 23, 2017

Current clang is starting to warn about deprecated c++03/c++98 features used in the implementation boost::function. The easiest way to disable them is to simply switch to std::function if it is available. And I think that using the std:: where possible is the correct long term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants