-
Notifications
You must be signed in to change notification settings - Fork 25
docker: add highlight.js to Noble v4 environment #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
It raises a question though: does asciidoctor need a (local) copy of the node package highlight.js to process files? Will it use the local highlight.js? Maybe this docker image will turn out to be unnecessary. If so, we can stay on 24.04-v3. |
|
Not sure if this answers your question, but it seems that we can decide on whether we need it locally vs CDN (default).
If we wanted to use a personal copy of a custom highlight.js build: |
|
There are distinct topics:
Perhaps "personal copy of a custom highlight.js build" is focused more on the second point, which is about viewing the docs. In terms of the first part (building the docs), this is the question: if anything is needed at all? Maybe asciidoctor has built-in support for generating highlights so npm packages aren't needed. If that's uncertain we can test with 24.04-v4 and then go back to 24.04-v3, comparing them. |
I believe it has built-in support. Because, in my experience working with asciidoctor (just building it on boostlook) I don't have to do anything in regards to npm packages. In this case, does it make this PR irrelevant? Oh, also, how could I compare the images? Locally? |
a simple test would be to run the new image cppalliance/boost_superproject_build:24.04-v4, with a mounted docker volume, build the docs inside the container, copy the docs out to the local machine via the volume, and compare the results to another set of docs. Inspect the asciidoctor pages. Are they correct?
It may be this PR is irrelevant. In which case, it can be closed. No rush though. Ultimately the published tag |
2193c73 to
4b5a25e
Compare
cppalliance/boost_superproject_build:24.04-v4CC @sdarwin