Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic move semantic for ptree #27

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

maciekgajewski
Copy link

Added move semantic for the container: move constructor and move assignment,
and also move versions of the following methods:

  • push_back
  • push_front
  • insert

In the future, I'd also like to add move versions of the put/add family.

@nvkhoi112358
Copy link

nvkhoi112358 commented Jun 14, 2024

Any reason that this is not accepted to master?
Also, I think the add_child should support move semantic too.
For big ptree, it cost a lot on copying.

Current I have to add/put first, then modify on returned reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants