-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing includes #112
Add missing includes #112
Conversation
It's hard to say what's the history here. I suppose this dates from the days when including So I assume people who were defining This problem will not occur today, because So adding this include is probably correct, but we need a test that shows why. |
As a general rule, every change that does not immediately fix a test failure needs to follow the procedure of: first commit adds a test that fails without the change, second commit adds the change that fixes the test failure. |
b5571f9
to
5210596
Compare
Would you please be able to extract the new test into a separate PR? I'd like to merge the original contribution (#101) as a form of giving credit on top of it. |
5210596
to
ce6c489
Compare
Then this PR is waiting for #100 response. |
ce6c489
to
76fe0d5
Compare
843349e
to
b7692c2
Compare
No description provided.