Skip to content

Refactor safe_max to improve stability and remove overload #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lighting9999 wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −7
Open

Refactor safe_max to improve stability and remove overload #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions include/boost/math/complex/details.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <cmath>
#include <complex>
#include <limits>
#include <algorithm>
#include <boost/math/special_functions/sign.hpp>
#include <boost/math/special_functions/fpclassify.hpp>
#include <boost/math/constants/constants.hpp>
Expand Down Expand Up @@ -41,13 +42,12 @@ inline std::complex<T> mult_minus_i(const std::complex<T>& t)
template <class T>
inline T safe_max(T t)
{
return std::sqrt((std::numeric_limits<T>::max)()) / t;
}
inline long double safe_max(long double t)
{
// long double sqrt often returns infinity due to
// insufficient internal precision:
return std::sqrt((std::numeric_limits<double>::max)()) / t;
static const T max_val = (std::numeric_limits<T>::max)();
static const T min_val = (std::numeric_limits<T>::min)();

// Prevent division by zero and overflow
T denominator = (std::max)(std::abs(t), min_val);
return std::sqrt(max_val) / denominator;
}

template <class T>
Expand Down