Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom color converter in dynamic_factory and added corresponding #726

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

nicolacandussi
Copy link
Contributor

Description

The function color_converted_view for dynamic views with a custom color converter ignores the provided color converter.
This pr fixes this issue as well as some compilation failures related to it. A corresponding test is included

@mloskot mloskot added the cat/bug But reports and bug fixes label Feb 8, 2023
@mloskot mloskot added this to the Boost 1.81+ milestone Feb 8, 2023
@mloskot
Copy link
Member

mloskot commented Feb 8, 2023

Great, thanks!

I will do my best to, over next days, investigate the CI failures with some older compilers, e.g.

====== BEGIN OUTPUT ======
libs/gil/test/extension/dynamic_image/image_view_factory.cpp(148): test 'equal_pixels_values(result_view, gil::const_view(expected_image), 1e-3f)' failed in function 'static void test_color_converted_view::run()'
1 error detected.

EXIT STATUS: 1
====== END OUTPUT ======

@mloskot mloskot added cat/annoyance Not a bug, not a feature, but something that should be improved and removed cat/bug But reports and bug fixes labels Feb 8, 2023
@nicolacandussi
Copy link
Contributor Author

I fixed the failing tests on Windows, that will probably fix the other CI failures for older compilers

@nicolacandussi
Copy link
Contributor Author

Is there anything else I can do to get this PR merged? There are other similar issues in dynamic_image/image_view_factory.hpp that I would like to fix after this PR is closed.

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder. This looks good, thanks!

@mloskot mloskot merged commit 8f4cdcb into boostorg:develop Feb 21, 2023
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83+ Mar 31, 2023
@striezel striezel mentioned this pull request Jun 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/annoyance Not a bug, not a feature, but something that should be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants