Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved 2D convolution and correlation #624

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Improved 2D convolution and correlation #624

wants to merge 15 commits into from

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Aug 5, 2021 •
edited
Loading

Description

Fixes #609
Fixes #610
Depends on #623

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@meshtag
Added all standard morphological transformations
f4369d1 
Improved comments and some other things

Applied adviced changes

Applied adviced changes

Should handle grayscale dilation/erosion

Checking
@meshtag
Merge branch 'develop' of https://github.com/boostorg/gil into develop
fe1621e
@meshtag meshtag marked this pull request as draft August 5, 2021 16:01
@meshtag meshtag force-pushed the 2D_Convolution_and_Correlation branch from 54032ec to caef575 Compare August 9, 2021 14:46
@meshtag meshtag force-pushed the 2D_Convolution_and_Correlation branch 2 times, most recently from bd01761 to aa7c069 Compare August 15, 2021 16:44
@simmplecoder @meshtag
Add matrix type and fix Hessian example
06fd700 
Sanitary_commit

1

2

3

4

5

5

5

Check Mac build

Change CI trigger trait
@meshtag meshtag force-pushed the 2D_Convolution_and_Correlation branch from aa7c069 to 06fd700 Compare August 15, 2021 16:53
@meshtag meshtag force-pushed the 2D_Convolution_and_Correlation branch from 0dc2e26 to 7513d31 Compare August 16, 2021 09:24
@meshtag meshtag marked this pull request as ready for review August 16, 2021 17:57
@meshtag
Copy link
Member Author

meshtag commented Aug 16, 2021 •
edited
Loading

Script used for comprehensive testing is here and folder containing expected, source images for those tests is here.

@meshtag meshtag force-pushed the 2D_Convolution_and_Correlation branch from c16c5b7 to 723499d Compare August 20, 2021 13:09
@meshtag meshtag added cat/enhancement Improvements, but not fixes addressing identified bugs google-summer-of-code All items related to GSoC activities labels Aug 21, 2021
@mloskot
Copy link
Member

mloskot commented Jun 3, 2022

@meshtag Could you tell what is the status of this PR? Is this going to be picked up or drop it and close it?

@mloskot mloskot added status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed! labels Jun 3, 2022
@meshtag
Copy link
Member Author

meshtag commented Jun 3, 2022

I will try to resolve merge conflicts and update this PR with latest version of the repository by the end of this weekend (will ping you once these PRs are ready for review). As far as usability is concerned, it was in a perfect working condition during my GSoC coding period. Same goes for #612 and #613 as well.

@mloskot
Copy link
Member

mloskot commented Jun 3, 2022

Sounds good. Yes, there has been lots of activity hence the conflicts.
If you will have trouble with resolving them and need help, let me know.

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #624 (c2c614d) into develop (843ea37) will decrease coverage by 3.61%.
The diff coverage is 12.45%.

@@             Coverage Diff             @@
##           develop     #624      +/-   ##
===========================================
- Coverage    78.76%   75.15%   -3.62%     
===========================================
  Files          117      117              
  Lines         5030     5296     +266     
===========================================
+ Hits          3962     3980      +18     
- Misses        1068     1316     +248

@meshtag
Copy link
Member Author

meshtag commented Jun 5, 2022 •
edited
Loading

@mloskot , I have resolved merge conflicts in above mentioned PRs but will have to obtain a closer look to examine why some CI builds are failing in this one. I'll try to do this in the coming week.

@simmplecoder simmplecoder mentioned this pull request Jun 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs google-summer-of-code All items related to GSoC activities status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide more boundary options in 2D convolution Add separate implementation of 2D correlation
3 participants
@meshtag @mloskot @simmplecoder