Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak fiber for macOS PPC #306

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Unbreak fiber for macOS PPC #306

merged 1 commit into from
Aug 18, 2023

Conversation

barracuda156
Copy link
Contributor

@olk Remember we were wondering why context was fixed but fiber failed? I preprocessed sources and found the cause. Of course this could not possibly work.

@barracuda156
Copy link
Contributor Author

Here are error we get with sources in fiber:

 /opt/local/bin/as -v -I . -arch ppc -o bin.v2/libs/fiber/build/darwin-12.2.0/release/threading-multi/visibility-hidden/algo/work_stealing.o bin.v2/libs/fiber/build/darwin-12.2.0/release/threading-multi/visibility-hidden/algo/work_stealing.s
Apple Inc version cctools-localbuild, GNU assembler version 1.38
bin.v2/libs/fiber/build/darwin-12.2.0/release/threading-multi/visibility-hidden/algo/work_stealing.s:2357:Parameter syntax error (parameter 1)

This is preprocessed source:

LVL172:
	.loc 22 66 21
; 66 "./boost/fiber/detail/spinlock_ttas.hpp" 1
	or 27,27,27
; 0 "" 2
	.loc 22 66 63

Bingo.

@barracuda156
Copy link
Contributor Author

@olk Could you review this please?

@olk
Copy link
Member

olk commented Jun 5, 2023

@olk Could you review this please?

Unfortunately I don't own a Mac or PPC system.

Did you run the unit tests in the subdirectory?

@barracuda156
Copy link
Contributor Author

@olk Not yet, but here it is merely a matter of wrong assembler syntax. On macOS registers must be prefixed with r (or f for float), so the existing code fails to build, and cannot build unless this is fixed.
(I fixed the same bug in Catch2, in Seqan3 and elsewhere. Pretty common.)

@barracuda156
Copy link
Contributor Author

@olk Could we merge this? Without it fiber simply does not build at all.

@olk olk merged commit 7ae9345 into boostorg:develop Aug 18, 2023
@olk
Copy link
Member

olk commented Aug 18, 2023

ty

@barracuda156 barracuda156 deleted the darwin branch August 18, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants