Fix ABI violation on ppc64 ELFv2, fixes #72#106
Merged
olk merged 1 commit intoboostorg:developfrom May 4, 2019
Merged
Conversation
The existing ontop_fcontext implementation for ppc64 ELFv2 violates the ABI by not storing the callback entry address in %r12 before branching. This results in crashes on this platform. This commit addresses this and allows the context library to function as expected on ppc64 platforms using the ELFv2 ABI.
|
I can confirm that the testsuite passes now (testing on Linux, POWER8 little endian). |
q66
added a commit
to OctaForge/libostd
that referenced
this pull request
May 4, 2019
|
This is exactly what I was seeing as the issue, thanks. |
Member
|
ty |
10 tasks
r-burns
added a commit
to r-burns/nixpkgs
that referenced
this pull request
Oct 21, 2020
Fixes NixOS/nix#2517 See also: boostorg/context#72 boostorg/fiber#193 These issues have been resolved by: boostorg/context#106 boostorg/context@d4608a4 which is merged into boost as of v1.71.0. This feature was introduced (with the bug) in boost v1.61 and was fixed in v1.71. So we apply the patch to all versions in that range.
10 tasks
r-burns
added a commit
to r-burns/nixpkgs
that referenced
this pull request
Oct 22, 2020
Fixes NixOS/nix#2517 See also: boostorg/context#72 boostorg/fiber#193 These issues have been resolved by: boostorg/context#106 boostorg/context@d4608a4 which is merged into boost as of v1.71.0. This feature was introduced (with the bug) in boost v1.61 and was fixed in v1.71. So we apply the patch to all versions in that range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing ontop_fcontext implementation for ppc64 ELFv2
violates the ABI by not storing the callback entry address
in %r12 before branching. This results in crashes on this
platform.
This commit addresses this and allows the context library
to function as expected on ppc64 platforms using the ELFv2 ABI.
The OpenPOWER ELFv2 ABI states on page 41, section 2.2.1.1: "r12 [...] Function entry address at the global entry point."