Further clean and fix the CMLs

[Flamefire]

Don't add C++ requiredment in test CML (added in root CML)

option does nothing when the variable is already set.

Also remove some redundancies (especially checks for BOOST_COBALT_IS_ROOT and BOOST_SUPERPROJECT_VERSION inside the "BOOST_COBALT_IS_ROOT"-branch)

Happy to help if any questions.

[klemens-morgenstern]

I think this is outdated now, what part is still relevant?

[Flamefire]

I resolved the conflicts. Please check if that looks ok

[klemens-morgenstern]

Why are you removing target_compile_features(boost_cobalt PUBLIC cxx_std_20) ?

[Flamefire]

I'm only removing the duplicated line which is (erroneously) in the test-CML. The actual correct one is still at

cobalt/CMakeLists.txt

Line 65 in 540b663

target_compile_features(boost_cobalt PUBLIC cxx_std_20)

Note on "erroneously": This is a requirement of the library so it needs to be set for the library by the library not by a user even though the "user" here is the tests of the library.

[klemens-morgenstern]

I removed the duplicate in test, is it ok now?

[Flamefire]

I removed the duplicate in test, is it ok now?

Synced and updated to see what is left:

• Unconditional dependency on Boost.Container (reformatting the other line allows the CMake scanner to work)
• Superflous include_directories: This should be covered by target_include_directories(boost_cobalt PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/include") unless you are missing a dependency on boost_cobalt

[Flamefire]

The change at https://github.com/boostorg/cobalt/pull/135/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL76-R78 was important because otherwise the dependency won't be detected by the dependency scanner in the super project build which requires it on its own line, see https://github.com/boostorg/cmake/blob/440dd10f57f86a91c9d0ae23f096f343fdd004cb/include/BoostRoot.cmake#L210

It seems to work though, I guess some dependency pulls it in transitively