Refactor: 미디어서버 HTTP Request 수정 및 백엔드 API 수정 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
platinouss
reviewed
Dec 13, 2023
mediaServer/src/RelayServer.ts
Outdated
| @@ -266,7 +267,7 @@ export class RelayServer { | |||
| await Promise.all([deleteRoomInfoById(data.roomId), deleteQuestionStream(data.roomId)]); | |||
|
|
|||
| // TODO: API 서버에 강의 종료 요청하기 | |||
| const url = await mediaConverter.getAudioFileUrl(data.roomId); | |||
| const url = mediaConverter.getAudioFileURL(); | |||
There was a problem hiding this comment.
이렇게 되면 saveAudioFile() 메서드 호출되기 전에 먼저 호출이 되서 url에 빈 값이 들어올 것 같아요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
여기에 작성하세요
작업 사항
여기에 작성하세요
고민한 점들(필수 X)
여기에 작성하세요
스크린샷(필수 X)
여기에 작성하세요